Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GDExtension support to XRInterface #52003

Merged

Conversation

BastiaanOlij
Copy link
Contributor

Adding extension support to XRInterface and retiring the old GDNative implementation.

@BastiaanOlij BastiaanOlij force-pushed the xr_interface_extension branch 3 times, most recently from 44a5974 to 5c5a6e0 Compare August 26, 2021 02:07
@BastiaanOlij BastiaanOlij marked this pull request as ready for review August 26, 2021 02:07
@BastiaanOlij BastiaanOlij requested review from a team as code owners August 26, 2021 02:07
@BastiaanOlij BastiaanOlij force-pushed the xr_interface_extension branch from 5c5a6e0 to a0219a2 Compare August 26, 2021 02:10
@BastiaanOlij
Copy link
Contributor Author

This is ready to be merged, I've removed some of the deprecated entry points as they will be re-implemented in a different way (see other PRs that re-introduce this logic) especially around the external texture support.

Also still working on the godot-cpp side of this but what is here is I believe finished and it would be good to have this work merged already so our extensions_api.json file is updated accordingly.

@BastiaanOlij BastiaanOlij force-pushed the xr_interface_extension branch from a0219a2 to 699855d Compare August 26, 2021 02:46
@BastiaanOlij
Copy link
Contributor Author

BastiaanOlij commented Aug 26, 2021

For some reason GDVIRTUAL2(_commit_views, RID, const Rect2 &); isn't getting added into our extensions_api.json file...

edit Forgot to include it in bind methods :)

@BastiaanOlij BastiaanOlij force-pushed the xr_interface_extension branch from 699855d to 1e12ded Compare August 26, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants